markdown version fix #459
Merged
markdown version fix #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipdemes
force-pushed
the
markdown_version_fix
branch
from
c527b79 to
8404e5c
Compare
|
Since it looks like there might be a fix released soon, and since not many folks seem to build the docs locally, I think doing nothing is also an acceptable short term solution, until the problem fixes itself. :) Otherwise, LTGM but ideally there would be a corresponding change in |
bryevdv
approved these changes
Jul 19, 2022
|
@bryevdv I think it would be safe to keep this restriction for some time. When new version of sphinx-markdown-tables is available, we will have to put a minimum version restriction on it. |
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Jul 29, 2022
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to add upper version for
markdowndue to some breaking changes to it that are not yet supported in the latest release of thesphinx-markdown-tables.Please see more details here: ryanfox/sphinx-markdown-tables#36