-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove broken/unsupported rapids_cpm_find usages in favor of rapids_find_package #5
Conversation
…pport downloading or building
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, assuming all the tests pass, and that it works fails with an appropriate message when we have to pull and build UCX.
@mdemoret-nv Do you remember why this was originally such a manual process?
@drobison00 the error produced by
|
Still need to test this with Morpheus now that the utilities changes have been merged there. |
I've kept the old code as a comment, per @mdemoret-nv 's request, and used |
tested with Morpheus and it works. Need to update one line in MRC to get this working, since I renamed the boost configuration function. |
@drobison00 I don't have permissions to change labels, but because of the boost configuration function rename this is a breaking change now. |
/merge |
/merge |
…272) Required to fix a breaking change in nv-morpheus/utilities#5 Authors: - Christopher Harris (https://github.com/cwharris) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #272
By using
rapids_cpm_find
we're implicitly stating that we support download and building packages. Excluding the CPM arguments from the call doesn't make it any better, since the error message produced byrapids_cpm_find
when it does not find the package installed indicates that the CPM arguments should be added. In short,rapids_cpm_find
doesn't do us any favors if we don't support downloading and building the package from source. Instead it just acts as a confusing wrapper aroundfind_package
. This PR replacesrapids_cpm_find
withrapids_find_package
and removes the broken build code forcudf
,ucx
, andboost
.If/when we decide to support building these packages from source, we can revisit
rapids_cpm_find
, but for now we require installing the packages ahead of time (this hasn't changed).