Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert installing pybind11 via conda and patch the dec_ref method #52

Conversation

dagardner-nv
Copy link
Contributor

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

We will likely need to continue installing pybind11 via CPM in the near future (MRC issue #362).
Will create a new PR moving to 2.10.4 via CPM.

This reverts commit b3d13be.
@dagardner-nv dagardner-nv requested a review from a team as a code owner August 17, 2023 22:57
@dagardner-nv dagardner-nv self-assigned this Aug 17, 2023
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change 3 - Ready for Review PR/Issue is complete and ready for review by team labels Aug 17, 2023
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5adffec into nv-morpheus:branch-23.11 Aug 17, 2023
@dagardner-nv dagardner-nv deleted the david-patch-pybind11-gil-dec-ref branch August 17, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review PR/Issue is complete and ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants