Fix MatX when building MRC and Morpheus in same environment. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mdemoret-nv
approved these changes
Sep 11, 2023
|
/merge |
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
Sep 12, 2023
…ironment (#1171) Adds a new `dependencies.yaml` which is used in RAPIDS devcontainer utils to generate conda env yamls, `project.toml`'s, and `setup.py`s on-the-fly using https://github.com/rapidsai/dependency-file-generator. Eventually we can generate/verify our existing environment files this way, but for now this gets us up and running in a RAPIDS devcontainer. Also fixes an issue where newer versions of Boost provide an overload to http request header `insert` where our existing usage would be ambiguous. MRC/Morpheus unified build environment is a WIP, but available here: https://github.com/cwharris/cyber-dev. Depends on nv-morpheus/utilities#55 Contributes to #704 Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unknown reasons, when building MRC and Morpheus within the same conda environment, MatX fails to see some c printf macros. Adding
__STDC_FORMAT_MACROSfixes the issue, though I'm curious as to why this wasn't a problem before. @mdemoret-nv, is there a better way to fix this?Contributes to nv-morpheus/Morpheus#704
Checklist