Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Numpy Dependency from CMake and Revert Boost Config #9

Merged
3 commits merged into from
Jan 27, 2023

Conversation

mdemoret-nv
Copy link
Contributor

This PR reverts a change in the Boost config to go back to the old method. The following section was found in the old config code:

  if (NOT Boost_ADDED)
    # Now add it to the list of packages to install
    rapids_export_package(INSTALL Boost
      ${PROJECT_NAME}-core-exports
      GLOBAL_TARGETS Boost::context Boost::fiber Boost::hana Boost::filesystem Boost::system
    )

    # Overwrite the default package contents
    file(WRITE "${CMAKE_BINARY_DIR}/rapids-cmake/${PROJECT_NAME}-core-exports/install/package_Boost.cmake" "find_dependency(Boost REQUIRED COMPONENTS context fiber filesystem system)")
  endif()

It's not immediately clear what this is doing, and its too risky to remove or blindly add back in at this point. Will need to readdress this after release.

MRC Conda build tested locally and working with this PR

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jan 27, 2023
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner January 27, 2023 06:42
@mdemoret-nv
Copy link
Contributor Author

Actually MRC docs now broken. Reverting UCX as well.

@mdemoret-nv
Copy link
Contributor Author

/merge

@ghost ghost merged commit b02f1ca into branch-23.01 Jan 27, 2023
@mdemoret-nv mdemoret-nv deleted the mdd_remove-numpy-cmake branch January 27, 2023 16:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants