Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIA console: when typing in the console, characters are wrongly pronounced regardless of the keyboard layout #10113

Closed
zstanecic opened this issue Aug 18, 2019 · 2 comments · Fixed by #10554
Milestone

Comments

@zstanecic
Copy link
Contributor

Steps to reproduce:

  1. open a console window with the uia console option turned on, for example a wsl console
    . switch to croatian or to the US keyboard language. I am not aware of other layouts having the problem which i will describe here thoroughly
    russian keyboard is also included there
  2. try to type or ], ; or ', \ or /

Actual behavior:

note: here are given the corresponding keys on the us keyboard. these keys are wrongly interpreted by NVDA also on oother non-us keyboard layout
for example / slash on US keyboard is interpreted as apostrophe,
; as č, the croatian diacritic mark, and so on.

Expected behavior:

the signs should be interpreded bz NVDA as these are written on the kezboard respectivelz

System configuration

NVDA installed/portable/running from source:

NVDA installed

NVDA version:

Latest alpha

Windows version:

18362 latest indows 10 1903

Name and version of other software in use when reproducing the issue:

n-a

Other information about your system:

to reproduce this bug, you should have turned on have character echo turned on

Other questions

Does the issue still occur after restarting your PC?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

n/a

@lukaszgo1
Copy link
Contributor

cc @codeofdusk

@codeofdusk
Copy link
Contributor

cc @codeofdusk

This is probably a bug with Windows keyboard hooks. Look at the block starting at around line 196 of the keyboardhandler module and the Win32 ToUnicodeEx function.

michaelDCurran added a commit that referenced this issue Nov 27, 2019
… saving them for exposia as windowThreadID in WinConsole NVDAObjects. Necessary for speak typed characters. Addresses #10113.
michaelDCurran added a commit that referenced this issue Nov 28, 2019
…econd try) (#10554)

* Track the true thread ID of winEvents for ConsoleWindowClass windows, saving them for exposia as windowThreadID in WinConsole NVDAObjects. Necessary for speak typed characters. Addresses #10113.

* Fix linting issues.

* Address review actions.
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants