Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UIA support and Braille not working #10191

Closed
vincent-lg opened this issue Sep 11, 2019 · 6 comments · Fixed by #10559
Closed

New UIA support and Braille not working #10191

vincent-lg opened this issue Sep 11, 2019 · 6 comments · Fixed by #10559
Milestone

Comments

@vincent-lg
Copy link

The support for UIA in console leads to a lot of problems in Braille.

Steps to reproduce

  1. Activate the UIA support for the Windows console in NVDA preferences.
  2. Start a console with a Braille display.
  3. And browse in review. No need to go far to see the problems.

Excerpt

Here is an excerpt for my own Windows console. When I open it, the review cursor is able to read the following:

Microsoft Windows [Version 10.0.17763.678]
(c) 2018 Microsoft Corporation. All rights reserved.

C:\Users\Admin>

My Braille display, when scrolling with the review cursor (with pavnum7 and pavnum9 on a computer keyboard) reads the following:

78]
 Corporation. All rights reserved.

CC:\Users\Admin>

(The CC on the last line doesn't appear the first time, it only appears when browsing back to it, which shows some problems.)

So I'd say there is a problem. And when using the Braille keys to scroll, things get even more weird. I don't think I need to supply a full transcript: comparing outputs in the previous transcripts should show lots of problems.

So I would highly advise: please don't merge it or do some proper testing in Braille. Although the feature can be turned off, it's definitely on by default.

I'll be happy to do further testing if need be.

Information:

  • Windows 10 (see signature above if needed)
  • NVDA snapshot: alpha-18590,50619158
  • Braille display: HandyTech ActiveBraille

Thanks!

@Adriani90
Copy link
Collaborator

cc: @codeofdusk, @LeonarddeR

@LeonarddeR
Copy link
Collaborator

LeonarddeR commented Sep 11, 2019 via email

@LeonarddeR LeonarddeR self-assigned this Nov 6, 2019
@LeonarddeR
Copy link
Collaborator

Turns out that the collapse method is broken when invoked for a textInfo that's positioned at the start of a line.

@LeonarddeR LeonarddeR removed their assignment Nov 6, 2019
@LeonarddeR
Copy link
Collaborator

Quick investigation revealed that it looks pretty complicated to fix this. Whatever I do with moving endpoints of the range, when positioned at the first character in the text, it simply refuses to collapse.

@zstanecic
Copy link
Contributor

zstanecic commented Nov 6, 2019 via email

@lukaszgo1
Copy link
Contributor

@zstanecic If you are still experiencing these problems please open separate issue for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants