winVersion: replace winVersion.winVersion/winVersionText with data coming from winVersion.WinVersion class

[josephsl]

Hi,

Blocked by #11837

Is your feature request related to a problem? Please describe.

winVersion module includes two variables (more towards constants) that record Windows version information:

• winVersion.winVersion: sys.getwindowsversion() tuple
• winVersion.winVersionText: text representation of Windows version information for use at startup and update checks

As noted on #11837, winVersion.WinVersion class and helper functions (including winVersion.getWinVer function) will record Windows version information for the current system and other Windows releases. Also, new constants will be added to winVersion module that will represent all supported Windows releases (for example, winVersion.WIN7_SP1) which can be used to provide rich comparisons, replacing version.major/version.minor checks and so on. Therefore, if winVersion.winVersion/winVersionText is kept, it will confuse developers.

Describe the solution you'd like

Remove winVersion.winVersion and winVersion.winVersionText altogether in favor of using winVersion.WinVersion class, winVersion.getWinVer function, and using winVersion.WIN* constants.

Describe alternatives you've considered

Leave winVersion.winVersion/winVersionText alone.

Additional context

This issue is blocked by #11837 and will be done as part of PR #11909 based on deprecation/removal comments recorded in the pull request mentioned. However, to provide backward compatibility for update checks, contents of winVersion.winVersion/winVersionText will be transfered to update check module in order to build version text as is done in 2020.4 and earlier (build string, service pack if any, product type).

Thanks.