UI Automation in Windows Console: backport some UIA console fixes to Python 2 (2019.2.1) #10274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls and disable the console bounds checking code when oldRange is also offscreen.
…ges to fix review top/bottom scripts.
Co-Authored-By: Reef Turner <[email protected]>
|
hi codeofdusk 2019.2.1 is mainly to fix the error master, which has exceeded the version range of 2019.2.1. |
|
Sorry, 2019.2.1beta1 has already been released, and 2019.2.1 is only going to contain critical bugs such as freezes and crashes. As the new Windows console support was behind an advanced settings option in this release, it is not necessary to address these bugs here. 2019.3 should be out in a couple of months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Backports #9944, #9957 (without user guide updates and py3 syntax), and #10052. This PR intentionally does not include #9771 or #9915 as they significantly alter NVDA functionality.
Summary of the issue:
Various issues with the UIA console implementation in 2019.2 (see linked PRs above).
Description of how this pull request fixes the issue:
Backported above PRs from
master.Testing performed:
See PRs mentioned above.
Known issues with pull request:
masterwill result in merge conflicts, but their resolution should be fairly obvious.Change log entry:
None.