Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Automation in Windows Console: remove workaround at POSITION_LAST for 21H1 #11713

Closed

Conversation

codeofdusk
Copy link
Contributor

Link to issue number:

microsoft/terminal#7771

Summary of the issue:

From winConsoleUIA.py:

# We must pull back the end by one character otherwise when we collapse to end,
# a console bug results in a textRange covering the entire console buffer!
# Strangely the *very* last character is a special blank point
# so we never seem to miss a real character.

This bug was fixed in microsoft/terminal#7792.

Description of how this pull request fixes the issue:

Removes the workaround for 21H1, restoring correct behaviour in the 21H1 console. The pre-21H1 console is unaffected.

Testing performed:

Tested in 21H1 console.

Known issues with pull request:

Visible range bounding is non-functional until microsoft/terminal#7803 is fixed (PR in pipeline, CC @carlos-zamora). Marking as a draft until a PR fixing visible range bounding has been merged.

Change log entry:

None needed.

@codeofdusk codeofdusk changed the title Cmduia rm end workaround UI Automation in Windows Console: remove workaround at POSITION_LAST for 21H1 Oct 2, 2020
@codeofdusk codeofdusk force-pushed the cmduia-rm-end-workaround branch from 0852a79 to 5f6be7a Compare October 2, 2020 05:06
@codeofdusk codeofdusk force-pushed the cmduia-rm-end-workaround branch from 5f6be7a to d3aad52 Compare October 2, 2020 05:09
@codeofdusk
Copy link
Contributor Author

Closing in favour of #11722.

@codeofdusk codeofdusk closed this Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant