UI Automation in Windows Console: Revert "downgrade E_FAIL when comparing selection changes to debugWarning"

[codeofdusk]

Link to issue number:

microsoft/terminal#5406

Reverts #11039.

Summary of the issue:

With the resolution of microsoft/terminal#5406, conhost now handles normal and alt buffer ranges correctly. NVDA currently filters out exceptions on detectPossibleSelectionChange, but we're no longer expecting any here, so these should be properly reported as errors.

Description of how this pull request fixes the issue:

Remove special exception handling in detectPossibleSelectionChange.

Testing strategy:

Tested that console works correctly.

Known issues with pull request:

None.

Change log entries:

None (only affected unreleased development builds)

Code Review Checklist:

• Pull Request description is up to date.
• Unit tests.
• System (end to end) tests.
• Manual testing.
• User Documentation.
• Change log entry.
• Context sensitive help for GUI changes.
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers

[michaelDCurran]

What is the reason this is still a draft?

[codeofdusk]

Blocked by microsoft/terminal#5406.

[codeofdusk]

Closing for now awaiting console changes, the lack of this change does not block UIA in consoles by default as it purely affects logging.