add (and default to on) --preview #6
+51
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this flag, the benchdiff output is rendered between each interleaved run of both the old and new benches (within the current package). Especially for longer benchmark runs, this is helpful to give an idea of what the results are likely going to be. In some cases, this may prompt the user to call it early, thus saving time. But it's also pleasant to be able to just check in, which is my primary motivation for this change.
RaduBerinde
approved these changes
Jan 24, 2025
| spinner.Update(progress) | ||
| var buf bytes.Buffer | ||
| if preview { | ||
| _, err := processBenchOutput(ctx, &buf, bs1, bs2, true, text, tests, nil) |
There was a problem hiding this comment.
Should we skip this when j==0? Not sure what it would show (maybe just the header columns?)
RaduBerinde
reviewed
Jan 24, 2025
| if err != nil { | ||
| return err | ||
| } | ||
| _, _ = fmt.Fprintln(&buf) |
There was a problem hiding this comment.
[supernit] There's an extra space because of how we're using the spinner. Maybe add a \n at the beginning of buf so it doesn't matter. Or change the spinner to not add the space if prefix is empty and use an empty prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this flag, the benchdiff output is rendered between each
interleaved run of both the old and new benches (within the current
package).
Especially for longer benchmark runs, this is helpful to give an idea
of what the results are likely going to be. In some cases, this may
prompt the user to call it early, thus saving time. But it's also
pleasant to be able to just check in, which is my primary motivation
for this change.