$HOME not being expanded properly in install script

[ndcampbell]

Hey,

It looks like a bug was introduced in #1381.

This can be replicated using:

INSTALL_DIR=$(printf %s "${NVM_DIR:-"$HOME/.nvm"}" | sed "s:^$HOME:\$HOME:")
echo $INSTALL_DIR
mkdir -p ${INSTALL_DIR}

this will create a directory literally named $HOME/.nvm. It does not expand $HOME.

It looks like this is happening due to the change at https://github.com/DesignByOnyx/nvm/blob/1b2305232f878db80ded5450a5accc881d4e8752/install.sh#L10

[ljharb]

Thanks, I'll take a look.

Since that change has not been released yet, this is not urgent. Please only use nvm from a tagged release, not off the master.

[ndcampbell]

Yeah, I understand. We ran into this because the Jenkins NVM wrapper plugin (https://github.com/jenkinsci/nvm-wrapper-plugin) pulls the install script from master. Ill see if I can get a patch into the project for pulling from a tag.

(Sorry, duplicate info. Communicating in the PR and this issue)

Thanks for taking a look!

[ljharb]

Filed jenkinsci/nvm-wrapper-plugin#3 to fix that they're depending on an unstable branch.