Fix is variable set test #1100
Merged
Fix is variable set test #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2166,7 +2166,7 @@ nvm() { | |||
| return 11 | |||
| fi | |||
| fi | |||
| if [ -n "$NVM_USE_OUTPUT" ]; then | |||
| if [ -n "${NVM_USE_OUTPUT:-}" ]; then | |||
There was a problem hiding this comment.
Thanks! I think this will work just as "${NVM_USE_OUTPUT-}" since there's no default value.
There was a problem hiding this comment.
I was actually hesitating with that form hehe. I will update.
ljharb
added
bugs
|
Not a huge deal, but it'd be awesome if when rebasing in the above comment, you changed the commit message so it starts with |
Updated. However, I wrote " |
ljharb
removed
the
needs followup
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, using the
nvm.shscript from another script where the check for unbound variables is on (set -u) will give the following error:Note
The issue described above occurs on an Ubuntu 14-04 environment Bash version 4.3.11.
However, it didn't occur on my MacBook Pro (v10.11.4) with Bash version 3.2.57.