Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use arm64 packages on aarch64 #1104

Merged
merged 1 commit into from
Jun 10, 2016
Merged

Use arm64 packages on aarch64 #1104

merged 1 commit into from
Jun 10, 2016

Conversation

ra100
Copy link
Contributor

@ra100 ra100 commented May 27, 2016

To install nodejs on aarch64 architecture you need to use arm64 packages. I just added new case to set correct $HOST_ARCH in this case.

@ljharb
Copy link
Member

ljharb commented May 27, 2016

Can you elaborate on what machines aarch64 would apply to?

@ljharb ljharb added the installing node Issues with installing node/io.js versions. label May 27, 2016
@ra100
Copy link
Contributor Author

ra100 commented May 27, 2016

I have aarch64 on Pine64. I'm not sure where else it applies.

@ljharb
Copy link
Member

ljharb commented May 30, 2016

@ra100 This seems fine to me - but I'd prefer to add unit tests to ensure that this doesn't unknowingly break, since tests aren't going to be run on this architecture.

@Unitech Unitech mentioned this pull request Jun 5, 2016
Closed
10 tasks
@Unitech
Copy link

Unitech commented Jun 5, 2016

that works well, it fixed nodejs installation on odroid c2

@ljharb ljharb added testing Stuff related to testing nvm itself. needs followup We need some info or action from whoever filed this issue/PR. labels Jun 5, 2016
@ra100
Copy link
Contributor Author

ra100 commented Jun 6, 2016

Sorry, I'm not sure which Unit tests whould be added. Maybe this would clarify this issue more build: treat aarch64 as arm64. Nodejs is treating aarch64 as arm64, but I'm not sure about iojs

@Unitech
Copy link

Unitech commented Jun 10, 2016

@ljharb do you have any idea where we could add this test?

@ljharb ljharb removed testing Stuff related to testing nvm itself. needs followup We need some info or action from whoever filed this issue/PR. labels Jun 10, 2016
@ljharb
Copy link
Member

ljharb commented Jun 10, 2016

Sorry for the delayed response.

Looking into it, nvm_get_os has no unit tests at the moment, or else that's where it would fit best. Given that, I'll accept this as-is (after it's rebased, if @ra100 doesn't mind)

Thanks!

@ljharb ljharb added the needs rebase Please rebase your branch onto latest master! This removes merge commits, & keeps the git log clean. label Jun 10, 2016
@ra100
Copy link
Contributor Author

ra100 commented Jun 10, 2016

Rebased :) You are welcome to merge.

@ljharb ljharb merged commit b648158 into nvm-sh:master Jun 10, 2016
@ljharb ljharb removed the needs rebase Please rebase your branch onto latest master! This removes merge commits, & keeps the git log clean. label Jun 10, 2016
@ljharb ljharb self-assigned this Jun 10, 2016
@emcniece emcniece mentioned this pull request Jun 23, 2016
Closed
@ljharb ljharb modified the milestone: v0.31.2 Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ljharb ljharb

Labels
installing node Issues with installing node/io.js versions.
Projects
None yet
Milestone
v0.31.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ra100 @ljharb @Unitech