-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly elaborated the instruction for manual install #1114
Conversation
Hi, I am a newbie and I see 2 labels to my PR - 'Informational' and 'needs rebase'. Please let me know if I am supposed to do anything about it or if it is just waiting for reviewer to merge. TIA, |
@brajpanda hi! sorry, I should have commented. This commit is based on 2 commits behind the latest master. If you could check it out locally, rebase it on top of the latest master, and force push, then I can merge it ASAP! I do see you created this on the web interface, so if that's a problem I can merge as-is. |
@ljharb Thanks for helping out. I have done a rebase and a force push. Do I have to create another PR? |
@brajpanda no, please don't create another PR :-) before you do the rebase, make sure to |
@ljharb Thanks, have done exactly that. |
I'm still not seeing it - can you make sure it's rebased on top of 36b1ea9 ? |
I did the following: Not sure what I am missing. |
@ljharb I think I know what is missing. I am fixing it. |
@ljharb I tried what is mentioned here: |
Hmm, I can't. No worries though, I'll just merge it :-) |
No description provided.