Fix nvm on SmartOS setups using 64 bits pkgsrc repository #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On SmartOS setups using 64 bits pkgsrc repositories, `nvm_get_arch` would not handle pkg_info's output properly. This would result in nvm not being to install any node binary when running on SmartOS setups using a 64 bits pkgsrc repository. This change fixes this problem, and fixes the tests suite on similar setups.
| @@ -1235,6 +1235,8 @@ nvm_get_arch() { | |||
| EXIT_CODE=$? | |||
| if [ $EXIT_CODE -ne 0 ]; then | |||
| HOST_ARCH=$(isainfo -n) | |||
| else | |||
| HOST_ARCH=$(echo "$HOST_ARCH" | tail -1) | |||
There was a problem hiding this comment.
thanks! do you think it's better to do the tail -1 on line 1234, when pkg_info is first called?
There was a problem hiding this comment.
That's what I was going for originally, but then it would mean that the EXIT_CODE value above would represent the exit code of tail -1, which would always be 0, and the rest of the current logic would be broken.
|
Thanks! Released in https://github.com/creationix/nvm/releases/tag/v0.31.4 |
|
@ljharb Thank you, very much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On SmartOS setups using 64 bits pkgsrc repositories,
nvm_get_archwould not handle pkg_info's output properly.
This would result in nvm not being to install any node binary when
running on SmartOS setups using a 64 bits pkgsrc repository.
This change fixes this problem, and fixes the tests suite on similar
setups.
Tested in separate SmartOS environments using a 32bits and 64bits pkgsrc repository respectively.