Update install.sh #1213
Update install.sh #1213
Conversation
| @@ -75,6 +75,8 @@ install_nvm_from_git() { | |||
| exit 1 | |||
| } | |||
| else | |||
| echo "=> Cleanup old nvm dir '$INSTALL_DIR'" | |||
| command rm -rf $INSTALL_DIR/* $INSTALL_DIR/.* | |||
There was a problem hiding this comment.
we absoLUTELY do not want to do this - this would delete previously installed node versions, along with all their global modules.
There was a problem hiding this comment.
What about backup the installed node versions and their modules first and restore after that?
There was a problem hiding this comment.
That's a lot of work - it would include all aliases, the "versions" folder, the upcoming cache folder, and all the pre-0.12 versions that are installed in the root.
If the issue is that installation is complaining about an existing directory, let's change that so it's not a problem, rather than removing the directory.
PeterDaveHello
force-pushed
the
patch-4
branch
5 times, most recently
from
29695ce
to
0947ead
Compare
|
@ljharb this should work now. |
| command git clone "$(nvm_source)" "$INSTALL_DIR" || { | ||
| command git init "$INSTALL_DIR" | ||
| command git --git-dir="$INSTALL_DIR"/.git remote add origin "$(nvm_source)" | ||
| command git --git-dir="$INSTALL_DIR"/.git fetch --tags |
There was a problem hiding this comment.
let's do git fetch origin --tags here, in case someone (like me) has multiple sources set up in their global git config.
PeterDaveHello
force-pushed
the
patch-4
branch
from
0947ead
to
2b01885
Compare
Clean up origin nvm directory before cloning nvm repository, fix nvm-sh#1212
|
Thanks! I ended up going with 68bf935 thanks to your inspiration. |
|
Hey ... why not make this PR work? I don't think it's a good idea to do another fix to close the exist one, I'm not leaving this PR without any response. I meant, no offense, of course you can write better codes, but that's not how open source community work, especially this problem is not in emergency, it's even been a while. |
|
@PeterDaveHello I apologize if I offended - it wasn't about "writing better codes", I just was able to reproduce it, and got a fix in. I'm hoping to get fixes in quickly to avoid churn for the install rewrite PR. I appreciate your contributions! |
|
Yeah I can understand your concerns, but as you know, this is not the first day we got the bug, I don't think it's emergency enough to take a working in process PR down with another one, thanks. |
Clean up origin nvm directory before cloning nvm repository, fix #1212