Manually run git gc after nvm installation, fix #1226 #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Sep 17, 2016
| @@ -109,6 +109,11 @@ install_nvm_from_git() { | |||
| command git --git-dir="$INSTALL_DIR"/.git --work-tree="$INSTALL_DIR" branch -D master >/dev/null 2>&1 | |||
| fi | |||
| fi | |||
|
|
|||
| echo "=> Compressing and cleaning up git repository" | |||
| if ! command git --git-dir="$INSTALL_DIR"/.git --work-tree="$INSTALL_DIR" gc --aggressive --prune=now ; then | |||
There was a problem hiding this comment.
can you confirm that this command works in git 1.5.5?
There was a problem hiding this comment.
Thanks for reminding.
git v1.5.5 does not support --prune with value, the interesting thing is the git gc --aggressive return Nothing new to pack., so give an upgrade request may be a better workaround.
There was a problem hiding this comment.
So to clarify - at what version does this command begin returning zero (either providing the desired behavior, or doing a no-op)?
There was a problem hiding this comment.
Should be fine from v1.6.2
* "git gc --prune" was resurrected to allow "git gc --no-prune" and
giving non-default expiration period e.g. "git gc --prune=now".
There was a problem hiding this comment.
This may be related to #1232
There was a problem hiding this comment.
So we don't have the problem here now since #1233 was merged!
PeterDaveHello
force-pushed
the
git-gc-after-installation
branch
from
490f564
to
68761c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.