Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Retab tab to 4 spaces in install.sh #1276

Merged
merged 1 commit into from
Oct 29, 2016

Conversation

PeterDaveHello
Copy link
Collaborator

No description provided.

=> longer be linked to the active version of Node when you install a new node
=> with `nvm`; and they may (depending on how you construct your `$PATH`)
=> override the binaries of modules installed with `nvm`:
=> You currently have modules installed globally with `npm`. These will no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://travis-ci.org/creationix/nvm/jobs/171280410 says that <<- can only use hard tabs, so this appears to be necessary?

Copy link
Collaborator Author

@PeterDaveHello PeterDaveHello Oct 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I should run shellcheck first, would you mind to use echo line by line as the other parts? Mixing spaces and tabs in the same file may be a little bit strange.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the mix as long as shellcheck passes, but sure, using nvm_echo is fine too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no nvm_echo in install.sh, I switched to use echo as the other parts in install.sh

=> override the binaries of modules installed with `nvm`:
echo "=> You currently have modules installed globally with `npm`. These will no"
echo "=> longer be linked to the active version of Node when you install a new node"
echo "=> with `nvm`; and they may (depending on how you construct your `$PATH`)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, looks like shellcheck is still failing. Let's single-quote all these lines since we're not doing any interpolation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@PeterDaveHello PeterDaveHello force-pushed the install.sh branch 3 times, most recently from 0d0afe8 to 6f3687c Compare October 29, 2016 03:13
@ljharb ljharb added informational installing nvm Problems installing nvm itself labels Oct 29, 2016
@ljharb ljharb merged commit a458ccb into nvm-sh:master Oct 29, 2016
@PeterDaveHello PeterDaveHello deleted the install.sh branch October 29, 2016 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
informational installing nvm Problems installing nvm itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants