-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Retab tab to 4 spaces in install.sh #1276
Conversation
=> longer be linked to the active version of Node when you install a new node | ||
=> with `nvm`; and they may (depending on how you construct your `$PATH`) | ||
=> override the binaries of modules installed with `nvm`: | ||
=> You currently have modules installed globally with `npm`. These will no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://travis-ci.org/creationix/nvm/jobs/171280410 says that <<-
can only use hard tabs, so this appears to be necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I should run shellcheck first, would you mind to use echo
line by line as the other parts? Mixing spaces and tabs in the same file may be a little bit strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind the mix as long as shellcheck passes, but sure, using nvm_echo
is fine too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no nvm_echo
in install.sh
, I switched to use echo
as the other parts in install.sh
0af25bf
to
2bcda5e
Compare
=> override the binaries of modules installed with `nvm`: | ||
echo "=> You currently have modules installed globally with `npm`. These will no" | ||
echo "=> longer be linked to the active version of Node when you install a new node" | ||
echo "=> with `nvm`; and they may (depending on how you construct your `$PATH`)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, looks like shellcheck is still failing. Let's single-quote all these lines since we're not doing any interpolation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
0d0afe8
to
6f3687c
Compare
6f3687c
to
a458ccb
Compare
No description provided.