Add AIX support #1295
Add AIX support #1295
Conversation
| else | ||
| HOST_ARCH="$(command uname -m)" | ||
| fi | ||
|
|
| if ( | ||
| [ -n "${TMPDIR-}" ] && \ | ||
| command mkdir -p "${TMPDIR}" && \ | ||
| command tar -x${tar_compression_flag}f "${TARBALL}" -C "${TMPDIR}" --strip-components 1 && \ | ||
| command $tar -x${tar_compression_flag}f "${TARBALL}" -C "${TMPDIR}" --strip-components 1 && \ |
There was a problem hiding this comment.
please surround the tar variable in quotes, and use curly braces for the expansion
| @@ -1693,6 +1699,7 @@ nvm_download_artifact() { | |||
| fi | |||
|
|
|||
| local SLUG | |||
| echo $NVM_ARCH | |||
There was a problem hiding this comment.
this seems like it's just here for debugging?
| @@ -1851,7 +1868,7 @@ nvm_install_source() { | |||
| [ -f "${TARBALL}" ] && \ | |||
| TMPDIR="$(dirname "${TARBALL}")/files" && \ | |||
| command mkdir -p "${TMPDIR}" && \ | |||
| command tar -x${tar_compression_flag}f "${TARBALL}" -C "${TMPDIR}" --strip-components 1 && \ | |||
| command $tar -x${tar_compression_flag}f "${TARBALL}" -C "${TMPDIR}" --strip-components 1 && \ | |||
| fi | ||
|
|
||
There was a problem hiding this comment.
please remove trailing whitespace
gdams
force-pushed
the
aix
branch
3 times, most recently
from
a8120e4
to
8f82eab
Compare
|
made those changes. AIX is an IBM platform, we have tested these changes on our AIX machines and observed no errors |
|
@GeorgeAdams95 yes but I need to be sure, going forward, that future changes don't break it, and relying on humans to test it isn't scalable. Is there any free open source CI platform that can run tests on AIX? |
|
@ljharb, It is very hard to get hold of AIX, let alone have a CI platform. Can we just add the code but not officially support the OS. It is only really going to be used by IBM and the Node.js community |
|
That's a lot of risk to take on. IBM is a member of the node foundation, I think if they want their OS supported, they need to invest in a way for it to be supported. |
Currently AIX isn't supported in nvm so I have made a few small changes to make this work: change tar to gtar for AIX change make to gmake for AIX Set ARCH as ppc64 for AIX
|
@ljharb AIX is supported in CI by the node foundation, see https://ci.nodejs.org/job/node-test-commit-aix/, pretty sure that was an IBM contribution. But that doesn't help nvm (not unless you convince the foundation to give you access to their CI, which I understand is under discussion, but they said no for now, unless I misremember the discussion). IBM isn't going to be afford to give every node project an AIX machine, and it can't convince Travis to have AIX, so.... where else do you think we should invest? How do we get more platform support into nvm? Do you suggest we just wait until nvm, or whatever the new working group comes up, has joined the foundation and then re-request this? The working group will likely want all the platforms on https://nodejs.org/en/download/ (you may not have noticed, but this includes AIX) to be supported, and this PR helps for nvm, at least. |
|
Thanks for the additional info. Given that AIX is a supported platform, and given that the node CI runs it (and that nvm doesn't need to be a foundation member to necessarily use the infra), I think this is worth taking now, even without tests. I would ask you to be vigilant about nvm changes in the future, and hopefully we can catch AIX breakage sooner than later, should it occur. |
|
@ljharb we will be hopefully using this often so hopefully can detect issues as they occur |
|
@ljharb thanks. I can confirm that we (IBM) contributed the AIX hardware to the node.js community and that we actively work to keep Node.js community CI jobs green across AIX and other platforms we've contributed H/W to the community CI for. As @sam-github says once the new version management workgroup makes progress lets make sure to revisit and if we get to the point were we can add CI coverage for nvm using the community infrastructure I'm happy to help to try and make that happen. In the mean time, @GeorgeAdams95 and @ljharb is there set of tests that can be easily run from Jenkins CI ? If so I'l see if @GeorgeAdams95 can look at adding a run at some interval in our internal CI. |
|
@mhdawson we could run the existing test suite on jenkins occasionally ? |
|
@mhdawson i'll look into it and see if we can run the existing tests on AIX in our CI |
Currently AIX isn't supported in nvm so I have made a few small changes to make this work:
-Change tar to gtar for AIX
-Change make to gmake for AIX
-Set ARCH as ppc64 for AIX