-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] add missing quotes for $NODE_VERSION in nvm-exec #1321
Conversation
Since NODE_VERSION has to be a proper semver single version number, is this something you've actually run into? Or is this just being careful? If the latter, we might as well make one PR that quotes all mistakenly unquoted vars in the project. |
It's just being careful, and then we could try to let shellcheck involve in all the shellscripts. |
If the goal here is to shellcheck |
Mean to let shellcheck involve in? |
I'm not sure if you'll like to disable SC1090 here?
|
yes, it should be disabled there just like it is in |
b3a0f63
to
a67021e
Compare
Done, maybe you can just cancel the old builds :) |
Tests passed 👍 |
No description provided.