Add missing backslash for dots #1322
Conversation
PeterDaveHello
changed the title
| @@ -116,7 +116,7 @@ export NVM_DIR="$HOME/.nvm" && ( | |||
| git clone https://github.com/creationix/nvm.git "$NVM_DIR" | |||
| cd "$NVM_DIR" | |||
| git checkout `git describe --abbrev=0 --tags --match "v[0-9]*" origin` | |||
| ) && . "$NVM_DIR/nvm.sh" | |||
| ) && \. "$NVM_DIR/nvm.sh" | |||
There was a problem hiding this comment.
The readme doesn't need the slash - virtually nobody actually aliases . to something.
There was a problem hiding this comment.
I'm a little bit confused ..., so nobody actually aliases . to something, why do we need to backslash them in some other places as the references?
There was a problem hiding this comment.
virtually nobody. One user did it, and as a requirement for accepting their change to \. in the script, i wanted the tests to exercise that too.
I don't want that going in the readme, though, to tacitly encourage the practice.
There was a problem hiding this comment.
So just remove the part in readme? What about line 77, 127?
There was a problem hiding this comment.
The only places . should be escaped are in actual code - not in documentation.
There was a problem hiding this comment.
Okay, should I remove all of it in readme? Thanks.
PeterDaveHello
force-pushed
the
fix-backslash-for-dots
branch
from
8da2250
to
043d0f2
Compare
ljharb
force-pushed
the
fix-backslash-for-dots
branch
from
043d0f2
to
7ed1e71
Compare
No description provided.