fix zsh node version autochange not installing node version #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PeterDaveHello (from #1306) - can you confirm that this is the correct fix? |
ljharb
requested changes
Dec 21, 2016
| @@ -322,7 +322,7 @@ load-nvmrc() { | |||
| if [ -n "$nvmrc_path" ]; then | |||
| local nvmrc_node_version=$(nvm version "$(cat "${nvmrc_path}")") | |||
|
|
|||
| if [ "$nvmrc_node_version" != "N/A" ] && [ "$nvmrc_node_version" != "$node_version" ]; then | |||
| if [ "$nvmrc_node_version" == "N/A" ] && [ "$nvmrc_node_version" != "$node_version" ]; then | |||
|
I'll test it 👍 |
|
I think putting |
|
yep that makes more sense |
|
so is this good? |
ljharb
requested changes
Jan 4, 2017
| @@ -322,8 +322,10 @@ load-nvmrc() { | |||
| if [ -n "$nvmrc_path" ]; then | |||
| local nvmrc_node_version=$(nvm version "$(cat "${nvmrc_path}")") | |||
|
|
|||
| if [ "$nvmrc_node_version" != "N/A" ] && [ "$nvmrc_node_version" != "$node_version" ]; then | |||
| if [ "$nvmrc_node_version" = "N/A" ] && [ "$nvmrc_node_version" != "$node_version" ]; then | |||
There was a problem hiding this comment.
the logic on this line says "if the nvmrc version is N/A and the node_version is not N/A", but nvm version doesn't print out N/A ever - so the second condition will always be true.
There was a problem hiding this comment.
yep your right changed
ljharb
approved these changes
Jan 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.