Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility Issues #726

Merged
merged 1 commit into from
Apr 13, 2015
Merged

Compatibility Issues #726

merged 1 commit into from
Apr 13, 2015

Conversation

SeeThruHead
Copy link
Contributor

No description provided.

@@ -186,6 +186,20 @@ nvm uninstall

$ nvm uninstall [tab][tab]
my_alias default v0.6.21 v0.8.26 v0.10.28

## Compatibility Issues
Nvm will encounter some issues if you have some non default settings set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lowercase nvm :-) also "non-default"

@ljharb
Copy link
Member

ljharb commented Apr 13, 2015

Thanks! Should the readme also link to the relevant issue?

@@ -126,7 +126,6 @@ Copyright (C) 2010-2014 Tim Caswell

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this removal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how that happened!

@ljharb
Copy link
Member

ljharb commented Apr 13, 2015

Thanks! Would you mind rebasing this down to one commit on latest master?

@@ -126,7 +126,7 @@ Copyright (C) 2010-2014 Tim Caswell

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the "-" is being added here?

@ljharb
Copy link
Member

ljharb commented Apr 13, 2015

Almost there, just the copyright notice lines still need reverting :-)

Sections includes warnings for cretain nonstandard path settings and environment variables that conflict with nvm.
ljharb added a commit that referenced this pull request Apr 13, 2015
README: Add note about `~/.npmrc` compatibility issues.

Relates to #606.
@ljharb ljharb merged commit de93dc4 into nvm-sh:master Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants