Match the layout of ENetAddress in enet.h #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The managed `ENetAddress` structure did not match the layout of the native
`ENetAddress` structure defined in enet.h.
The native structure has an additional field, so add that same field to
the corresponding managed structure.
Without this field in the managed structure, p/invoke calls into the
native code will marshal it with some arbitrary value in the native side
of the field, which can lead to unexpected problems. This happens with
Unity's IL2CPP, for example.
Fixes #13
|
Thank you Josh, merged. I missed this one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The managed
ENetAddressstructure did not match the layout of the nativeENetAddressstructure defined in enet.h.The native structure has an additional field, so add that same field to
the corresponding managed structure.
Without this field in the managed structure, p/invoke calls into the
native code will marshal it with some arbitrary value in the native side
of the field, which can lead to unexpected problems. This happens with
Unity's IL2CPP, for example.
Fixes #13