Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix for deprecated eslint rule #165

Merged
merged 2 commits into from
Sep 15, 2016
Merged

chore: fix for deprecated eslint rule #165

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7ff603
chore: temp fix for upstream eslint-plugin-import issue
cwonrails Sep 15, 2016
c7dadc3
fix: remove unnecessary jsx extension rule
cwonrails Sep 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"prefer-reflect": 2,
"no-warning-comments": [1, { "terms": ["todo", "fixme"], "location": "start" }],
"react/sort-comp": 0,
"react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }],
"react/require-extension": "off",
"import/extensions": [1, { "js": "never", "jsx": "never" }],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove jsx here since kyt doesn't support that extension.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pushed, let me know if I should squash or amend the original instead based on the Times' preference.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We squash & merge PRs, so it should be fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can squash when we merge from github so separate commits is fine

Copy link
Contributor Author

@cwonrails cwonrails Sep 15, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Here's the followup commit: c7dadc3

"import/no-unresolved": [2, { "ignore": ["ava"] }],
"import/no-extraneous-dependencies": [0],
"no-param-reassign": 0
Expand Down