eslint config gets linked or copied depending on where it comes from #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| // Create a symbolic link from our local eslint | ||
| const esLintPath = path.join(userRootPath, 'node_modules/kyt/eslint.json'); | ||
| if (shell.ln('-s', esLintPath, linkedPath).code === 0) { |
There was a problem hiding this comment.
Symlink needs to be relative, see #44
There was a problem hiding this comment.
will do thanks!
|
ok Adding a few updates here
one note: |
|
@tizmagik I can't figure out to reply to our original thread. I'm going work on making setup interactive as a whole so I'd like to defer your note until then. that ok? |
|
@ccpricenytimes oh that's great! Yea that sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an eslint.json to user's repo:
copies from a starter-kyt if one exists (this is something that would go hand in hand with a starter-kyts kyt.config.js)
or
copies default from kyt
connects #47