Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect GuildUpdateBuilder & overwrites serialization #596

Conversation

MCausc78
Copy link
Contributor

@MCausc78 MCausc78 commented Dec 1, 2023

Description

<title> and added safety alerts channel id to GuildUpdateBuilder

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

lib/src/builders/permission_overwrite.dart Show resolved Hide resolved
test/unit/builders/permission_overwrite_test.dart Outdated Show resolved Hide resolved
lib/src/builders/guild/guild.dart Outdated Show resolved Hide resolved
@abitofevrything abitofevrything merged commit c1eab88 into nyxx-discord:dev Dec 2, 2023
3 checks passed
@MCausc78 MCausc78 deleted the bug/incorrect-guild-update--overwrites-serialization branch December 4, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants