Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn when submodules missing #1898

Merged
merged 1 commit into from
Nov 17, 2024
Merged

warn when submodules missing #1898

merged 1 commit into from
Nov 17, 2024

Conversation

Geometer1729
Copy link
Member

Here I just steal the code from mina to give a useful warning when using nix develop .
closes #1896

@Geometer1729 Geometer1729 marked this pull request as ready for review November 15, 2024 14:27
@Geometer1729 Geometer1729 requested a review from a team as a code owner November 15, 2024 14:27
@Fizzixnerd
Copy link
Contributor

on Ubuntu with nix installed, I tried:

git checkout brian/submodule-warn
nix develop .

The output was:

fizzixnerd@o1-walkerbook:~/src/o1js$ nix develop .
warning: Git tree '/home/fizzixnerd/src/o1js' is dirty
error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:34:12:
           33|
           34|   strict = derivationStrict drvAttrs;
             |            ^
           35|

       … while evaluating derivation 'nix-shell'
         whose name attribute is located at /nix/store/g8zzlf6drg73c987ii390yicq4c0j778-source/pkgs/stdenv/generic/make-derivation.nix:348:7

       … while evaluating attribute 'nativeBuildInputs' of derivation 'nix-shell'
         at /nix/store/g8zzlf6drg73c987ii390yicq4c0j778-source/pkgs/stdenv/generic/make-derivation.nix:392:7:
          391|       depsBuildBuild              = elemAt (elemAt dependencies 0) 0;
          392|       nativeBuildInputs           = elemAt (elemAt dependencies 0) 1;
             |       ^
          393|       depsBuildTarget             = elemAt (elemAt dependencies 0) 2;

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: lib.fileset.unions: Element 0 (/nix/store/llhbnzfyq8jsy5qwdpi65j9birn2bvgh-source/src/bindings/ocaml/dune) is a path that does not exist.
           To create a file set from a path that may not exist, use `lib.fileset.maybeMissing`.

@Fizzixnerd
Copy link
Contributor

Rerunning pin.sh after checkout fixed it.

@Fizzixnerd
Copy link
Contributor

Tried a fresh clone, and it works.

@Geometer1729 Geometer1729 merged commit 0ccf4a6 into main Nov 17, 2024
27 of 28 checks passed
@Geometer1729 Geometer1729 deleted the brian/submodule-warn branch November 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nix develop . fails upon fresh checkout
3 participants