Remove polymorphism from As_prover.t, hoist Typ.t
#854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/base/as_prover0.ml
Outdated
| module Handle = struct | ||
| let value (t : ('var, 'value) Handle.t) : ('value, 'field) t = | ||
| fun _ -> Option.value_exn t.value | ||
| type nonrec ('a, 'f) t = ('a, 'f) Types.Provider.t |
There was a problem hiding this comment.
It was confusing first that the type changes. But ok :).
| @@ -1,46 +1,5 @@ | |||
| open Core_kernel | |||
|
|
|||
| module Data_spec0 = struct | |||
| @@ -58,8 +58,6 @@ module Typ = struct | |||
| ('var, 'value, 'aux, 'field, 'checked) typ' | |||
| -> ('var, 'value, 'field, 'checked) typ | |||
| end | |||
|
|
|||
| include T | |||
src/base/checked_runner.ml
Outdated
| @@ -15,7 +15,41 @@ module Simple_types = struct | |||
| end | |||
|
|
|||
| module Typ = struct | |||
| include Types.Typ.T | |||
src/base/checked_intf.ml
Outdated
|
|
||
| val run : 'a t -> field Run_state.t -> field Run_state.t * 'a | ||
| end | ||
|
|
||
| module Unextend |
dannywillems
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles a few changes. This can be broken into smaller pieces by commit if needed.
The goal of this PR is to remove the generalisation over
Field.tfromChecked.tandAs_prover.t, allowing us to hoistTyp.tfrom the global implementation inTypes. The result is a uniqueTyp.ttype for each instantiation of snarky, allowing us to generate it from any checked backend (and in particular from a rust backend).To achieve this, we
Types.Make_typesAs_prover.tTypesmodule signatureThe recommended way to review this PR is to 'ignore whitespace' in the GitHub UI (or equivalently using
git diff --ignore-all-space), to ignore the indentation changes resulting from functorisation.