Abstract over Run_state, include it in the snarky backend
#858
Conversation
| @@ -0,0 +1,89 @@ | |||
| module Vector : sig | |||
There was a problem hiding this comment.
Wondering if making an external library for vectors (and the other types we use in Pickles) would make sense. Could be nice for the OCaml community too.
There was a problem hiding this comment.
Not blocking, but I don't understand why we have the nested module Vector with the methods, and externally we do have only the type, both types being equal.
| @@ -341,12 +349,14 @@ struct | |||
| Checked_intf.Basic | |||
| with module Types := Types | |||
| with type field := Checked_runner.field | |||
| and type run_state := run_state | |||
There was a problem hiding this comment.
Not blocking: wondering if we could not remove some type aliases above to simplify the interface. type state = run_state for instance. Only looking at the lines above, it might not make sense as used for something else.
| @@ -215,7 +217,7 @@ struct | |||
| Runner.State.make ~num_inputs ~input ~next_auxiliary ~aux ~system | |||
| ~with_witness:false () | |||
| in | |||
| let id = Run_state.id state in | |||
| let id = Backend.Run_state.id state in | |||
There was a problem hiding this comment.
Nit: this doesn't seem to be useful (compiles without on my side), as the module is opened L21. Or, are you trying to remove the statements open 🥹?
| @@ -714,7 +715,7 @@ module Run = struct | |||
|
|
|||
| module Make_basic (Backend : Backend_intf.S) = struct | |||
| module Snark = Make (Backend) | |||
| open Run_state | |||
| open Backend.Run_state | |||
There was a problem hiding this comment.
It seems we can remove this open by changing L1564. See 242d5b5.
There was a problem hiding this comment.
Suggesting as everywhere we use the full path.
This PR abstracts over
Run_state, accepting it as a parameter from the snarky backend. This allows us to pass through a rust implementation in place of the default OCaml implementation.