Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI builds #6

Closed
wants to merge 2 commits into from
Closed

Fix CI builds #6

wants to merge 2 commits into from

Conversation

avlitman
Copy link
Member

@avlitman avlitman commented Jan 4, 2022

update the folder automation to .automation

Signed-off-by: Aviv Litman [email protected]

update the folder automation to .automation

Signed-off-by: Aviv Litman <[email protected]>
@avlitman
Copy link
Member Author

avlitman commented Jan 4, 2022

@mwperina I will appreciate your review.

@mwperina
Copy link
Member

mwperina commented Jan 4, 2022

Please take a look at #7

The missing parts here are .automation/build-rpm.sh and .automation/build-srpm.sh:

The whole automation directory is just for STDCI and can be removed once GH CI is working.

So you can abandon this patch and merge #7 and please take a look carefully to understand the build flow

@avlitman
Copy link
Member Author

avlitman commented Jan 4, 2022

Please take a look at #7

The missing parts here are .automation/build-rpm.sh and .automation/build-srpm.sh:

The whole automation directory is just for STDCI and can be removed once GH CI is working.

So you can abandon this patch and merge #7 and please take a look carefully to understand the build flow

+1 Thank you!
I will abandon this patch, merge #7 and create a new pr for removing the automation directory.

@avlitman avlitman closed this Jan 4, 2022
@avlitman avlitman deleted the fix-builds branch January 5, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants