Fix execution of RemoveImage #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
requested review from
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
ahadas
force-pushed
the
fix_remove_image
branch
from
8b0ca88 to
e0a1c82
Compare
mkemel
reviewed
Dec 5, 2022
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Show resolved
Hide resolved
|
/ost |
ok, something is wrong with the OST action.. |
mkemel
approved these changes
Dec 5, 2022
RemoveImage now attaches the created async task to itself rather than to its parent command and its EndProcedure type is changed to COMMAND_MANAGED. With these changes, first the execution of RemoveImage is completed and then its parent's callback detects it and completes the execution of the parent command. Signed-off-by: Arik Hadas <[email protected]>
RemoveImage may lack async tasks when: 1. The image doesn't exist 2. There's a failure during delete image With these changes, the image is removed from the database (rather than staying in LOCKED state) and the command would finish successfully in the first case, and in the second case the command end with failure and the image switches to ILLEGAL state. Signed-off-by: Arik Hadas <[email protected]>
ahadas
force-pushed
the
fix_remove_image
branch
from
e0a1c82 to
d08c4bc
Compare
bennyz
approved these changes
Dec 5, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes:
RemoveImage now attaches the created async task to itself rather than to
its parent command and its EndProcedure type is changed to COMMAND_MANAGED.
With these changes, first the execution of RemoveImage is completed and
then its parent's callback detects it and completes the execution of the
parent command.
RemoveImage may lack async tasks when:
With these changes, the image is removed from the database (rather than
staying in LOCKED state) and the command would finish successfully in
the first case, and in the second case the command end with failure and
the image switches to ILLEGAL state.