Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning explicit error should not revert state but panic should #129

Open
nhynes opened this issue Jun 30, 2019 · 0 comments
Open

Returning explicit error should not revert state but panic should #129

nhynes opened this issue Jun 30, 2019 · 0 comments

Comments

@nhynes
Copy link
Contributor

nhynes commented Jun 30, 2019 •
edited
Loading

For instance, it's not hard to imagine a callee that wants to log that it was called incorrectly.

A wasi non-zero exit code should signal that an explicit error occurred. Wasm unreachable should signal a panic.
dm4 pushed a commit to second-state/oasis-parity that referenced this issue Jul 20, 2020
@ptrus
Merge pull request oasislabs#129 from oasislabs/ptrus/feature/fix-pro…
bbdf6e2 
…mote-to-production

Fix 'promote-to-production' step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nhynes