Fix voting process stopping with each synchronization #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RelatedCode: - eth/downloader/downloader.go#L463 - core/vote/vote_manager.go#L108-L110)
ironbeer
changed the title
tak1827
approved these changes
Oct 31, 2024
tak1827
added a commit
that referenced
this pull request
Oct 31, 2024
* Configured block time shortening epoch for the mainnet * Fix block time shortening epoch for the mainnet * Feat/finalizer (#61) * copy new files from [email protected] * copy from bsc v1.4.6 * resolve interface missing method error for mock structs * apply finality to our consensus * add oasys consensus test: env/validators assemble * whether broadcast vote judging from peers's TD * fix lots of error to make work voting * increase vote DOS threadhold * fix lint error * modify go.mod according to BSC * vote attestaion stake weighted * add MaliciousVoteMonitor * remove bsc dependent comments/message * rename finalizer to fast finality * replace genesis contract by v1.6.0 * update genesis contract submodule (v1.6.0) * resolved several consensus issue * increment version to v1.6.0 * print error log: prepareWork and commit * print warn log in case of invalid vote * sort validators by owner for fast finality * apply validators sort changes to snapshot.go * disable deployments11 * refactor consensus * upgrade stake manager contract version * delete unused CeilDiv function * delete unused metrics.label file copyed from bsc * add comment to formHeader of finalize and seal case * add comment why disable fromHeader on Finalize * fix mainnet sync error: failed to verify header * fix getValidators marshal error by suppporting old contract interface * commit leak of previous one * fix verify header error by adding missing return * deal with unexpected value is presented to callGetHighStakesCommon * fix getHighStakes unpack error. replace wrong contract * sort by owner only fast finality enabled * Improved performance degradation due to change in json format of consensus snapshot * Improved EnvironmentValue parsing (#70) * Add note to BLSPublicKey's Marshaler * fix null pointer error after taking #69 * temporary set testnet hardfork for private testnet * increase private testnet hardork block * bring private hardfork time closer * fix feedback from @ironbeer part1 * vot validator point to parent block(=target block) * Add contract deploy test * Update consensus/oasys/snapshot.go Co-authored-by: ironbeer <[email protected]> * fix feedback from ironbeer part2 * Added `Equal` method to EnvironmentValue (#71) * Imported diffs of blockchain.go and headerchain.go from [email protected] (#74) * Imported diffs of blockchain.go and headerchain.go from [email protected] * Imported fast finality reorganization from [email protected] (#75) * Imported fast finality reorganization from [email protected] * Fix errors in test code * elaborate the timeing update finalized and justified gauge (#77) --------- Co-authored-by: tak <[email protected]> * Fix panic when BLS key is nothing & support multiple keys (#81) * Imported eth.handler from [email protected] (#78) * Imported stop process of eth.handler from [email protected] * Imported `chainFinalizedHeightFn` of fetcher.BlockFetcher from [email protected] * remove stop chan from eth/handler (#82) --------- Co-authored-by: tak <[email protected]> * fix feadback from ironbeer part3 * Fix reorg when justification chain is split (#85) * update loas contract & reset testnet hardfork schedule * Fix misc (#87) * Fix test error * Fix image build error --------- Co-authored-by: ironbeer <[email protected]> * set testnet hardfork for v1.6.0 (#88) * Fix voting process stopping with each synchronization (#90) * Fix nil panic in td.Cmp(bestTd) * Fix voting process stopping with each synchronization. RelatedCode: - eth/downloader/downloader.go#L463 - core/vote/vote_manager.go#L108-L110) --------- Co-authored-by: ironbeer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downloaderの同期処理が走る度にvoting_poolが停止するためSafeブロックがひとつ飛ばしで行われるようになっていました。