-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: make sure that unrelated snapshots are passing CI #956
tests: make sure that unrelated snapshots are passing CI #956
Conversation
How is CI passing on this, but also #957 ??? |
Is it possible you have some kind of cargo config that isn't in environment variables? Perhaps a These lines currently attempt to remove any non-reproducible configs, but perhaps they need to be adjusted to override env var values instead of merely removing them. This is because removals will make cargo fall back to other config, whereas overriding the env vars with desirable values will force cargo to explicitly apply the behavior we want instead of using default-or-otherwise-configured settings. Could you see if changing those lines to explicitly set the env vars you've identified as necessary will fix the problem? |
This reverts commit 72c557c.
can't really find why setting the environment varibles does not change the output of the snapshots. |
My guess is this. On CI, the On your local system, you have a Env vars take precedence over config file settings, so setting the env vars fixes the problem you're seeing. On CI, it has no effect because the set env vars are applying values that are already the defaults. I would go through the paths mentioned here and look through any files they contain to find where the configs are set: https://doc.rust-lang.org/cargo/reference/config.html |
Hmm I'm not sure then. I'm not sure there's a way to ask cargo to list all the sources of configuration it's reading... Consider posting on https://users.rust-lang.org/ to see if someone there has an idea? |
These changes seem nessesary from my point of view via running
cargo test
.Lets see if CI agrees with me and something has changed between b65ccab and now or if my environment is faulty in this regard