Chore: use SSE to deliver change event for knowledgefiles #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
use-sse-event
branch
from
7cdfff6 to
8609fcf
Compare
StrongMonkey
commented
Jan 3, 2025
| @@ -141,9 +141,6 @@ export default function FileTreeNode({ | |||
| filePathPrefixInclude, | |||
| filePathPrefixExclude, | |||
| }); | |||
|
|
|||
| // We should manually approve/unapprove all files in the folder at once so that we don't rely on backend reconciliation logic as it will cause delay in updating the UI. | |||
There was a problem hiding this comment.
It seems not ideal to approve files in frontend just for fast feedback from UI. I think it is ok to just rely on backend to reconcile all the files to be approved.
StrongMonkey
requested review from
thedadams,
njhale,
iwilltry42,
ryanhopperlowe,
g-linville and
ivyjeong13
ryanhopperlowe
approved these changes
Jan 3, 2025
|
|
||
| eventSource.onmessage = (event) => { | ||
| const payload = JSON.parse(event.data); | ||
| const { eventType, knowledgeFile } = payload; |
There was a problem hiding this comment.
can you create a type for this?
Signed-off-by: Daishan Peng <[email protected]>
thedadams
requested changes
Jan 6, 2025
pkg/api/handlers/agent.go
Outdated
|
|
||
| for event := range w.ResultChan() { | ||
| if knowledgeFile, ok := event.Object.(*v1.KnowledgeFile); ok { | ||
| payload := map[string]interface{}{ |
There was a problem hiding this comment.
nit:
Suggested change
| payload := map[string]interface{}{ | |
| payload := map[string]any{ |
pkg/api/router/router.go
Outdated
| @@ -11,7 +11,7 @@ import ( | |||
| func Router(services *services.Services) (http.Handler, error) { | |||
| mux := services.APIServer | |||
|
|
|||
| agents := handlers.NewAgentHandler(services.GPTClient, services.Invoker, services.ServerURL) | |||
| agents := handlers.NewAgentHandler(services.GPTClient, services.Invoker, services.ServerURL, services.StorageClient) | |||
There was a problem hiding this comment.
The api.Context object passed to each of these handlers already has a client. Can we just use that one instead?
There was a problem hiding this comment.
Good call! addressed
Signed-off-by: Daishan Peng <[email protected]>
thedadams
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to pull knowledge at an interval but this is not effiencient. Switching to use SSE events to watch for changes.