New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unsafe cast and redundant @ExtendWith #333

Merged

davideicardi merged 1 commit into obsidiandynamics:master from vojkog:AbstractIntegrationTest-Simplification

Jan 11, 2022

Contributor

vojkog commented Jan 10, 2022

Constructor of MapPropertySource receives Map<String,Object> source so we may avoid unsafe casting:

Javadoc: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/core/env/MapPropertySource.html#MapPropertySource-java.lang.String-java.util.Map-

Also: @ExtendWith(SpringExtension.class) is already included in @SpringBootTest:

Javadoc: https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/test/context/SpringBootTest.html


          remove unsafe cast and redundant @ExtendWith

d97c9a0

davideicardi approved these changes

View reviewed changes

Collaborator

davideicardi left a comment

LGTM

davideicardi merged commit ab11833 into obsidiandynamics:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet