Fix message formatting when max scan count is exceeded. #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monterinio
force-pushed
the
fix-msg-formatting
branch
from
eb19acb
to
6e6411b
Compare
Bert-R
requested changes
Dec 1, 2023
Comment on lines
283
to
284
| "Search timed out after scanning %d messages. Last scanned message timestamp was %s. Adjust your time" + | ||
| " span for more results.", |
There was a problem hiding this comment.
Can't we just fix the format?
Suggested change
| "Search timed out after scanning %d messages. Last scanned message timestamp was %s. Adjust your time" + | |
| " span for more results.", | |
| "Search timed out after scanning %1$d messages. Last scanned message timestamp was %2$tF %2$tT. Adjust your time" + | |
| " span for more results.", |
| records.getMessagesScannedCount(), | ||
| records.getFinalMessageTimestamp())); | ||
| records.finalMessageTimestampFormatted())); |
There was a problem hiding this comment.
Suggested change
| records.finalMessageTimestampFormatted())); | |
| records.getFinalMessageTimestamp())); |
|
I will adjust as requested today's evening! Thanks. |
Bert-R
reviewed
Dec 5, 2023
Co-authored-by: Bert Roos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.