Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix "Add chart-release actions workflow #630" by using charts_… #631

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

florianbachmann
Copy link
Contributor

…dir: chart

This PR tries to use the charts_dir directive, because in this repo the name is chart instead of the default charts.

Related: #236, #357, #360

Copy link
Collaborator

@Bert-R Bert-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bert-R Bert-R merged commit 7569e4a into obsidiandynamics:master Apr 3, 2024
1 check passed
@Bert-R
Copy link
Collaborator

Bert-R commented Apr 3, 2024

Now it failed as follows:

Looking up latest tag...
Discovering changed charts since '4.0.1'...
WARNING: chart/templates/Chart.yaml is missing, assuming that 'chart/templates' is not a Helm chart. Skipping.
Nothing to do. No chart changes detected.

I'm afraid this is not going to work. See helm/chart-releaser-action#87 and helm/chart-releaser-action#132.

@Bert-R
Copy link
Collaborator

Bert-R commented Apr 6, 2024

@florianbachmann / @FieteO: Ideas how to get this fixed? If not, I take it out again.

@FieteO
Copy link
Contributor

FieteO commented Apr 7, 2024

Wee could try to move the chart into the subfolder.
I can do that in the next days if none of you want to try it

@Bert-R
Copy link
Collaborator

Bert-R commented Apr 11, 2024

That is not going to fix it. The action is not created for a source code repository that also contains a chart. See this comment. I'm going to remove the work flow.

Bert-R added a commit that referenced this pull request Apr 11, 2024
Bert-R added a commit that referenced this pull request Apr 12, 2024
@QuinnBast
Copy link

QuinnBast commented Jul 8, 2024

Very sad :(

Would love to see your chart in a public repository as our main workflows for deployment rely on this...
We have to maintain a custom fork specifically to host your chart in a local helm repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants