Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: MOC Modal Binder #5237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sniper-fly
Copy link

@sniper-fly sniper-fly commented Jan 26, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/sniper-fly/MOC-ModalBinder

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot changed the title Add plugin: [MOC Modal Binder] Add plugin: MOC Modal Binder Jan 26, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 27, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@joethei
Copy link
Collaborator

joethei commented Feb 12, 2025

name: "Open MOC Selector",, .setName("Auto Bind")
Use sentence case in UI

if (file instanceof TFile && this.settings.autoBind === true) {
You might also want to check that file.extension === 'md, as otherwise this will also get triggered for inserted images.

this.registerEvent(
And register this event in onLayoutReady as this event get's called for each file when Obsidian starts up, putting it into onLayoutReady will stop that from happening.

strong {
You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

style={{, style={{, style={{, style={{
This should be declared in styles.css and not in the react file.

@joethei joethei self-assigned this Feb 12, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants