-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: Media Slider #5405
base: master
Are you sure you want to change the base?
Add plugin: Media Slider #5405
Conversation
Hello!I found the following issues in your plugin submission Errors: ❌ Please don't include This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obsidian in description removed
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. [1][2][3][4]:You should not cast this, instead use a Optional[1][2]:Casting to Do NOT open a new PR for re-validation. |
Changes requested by bot have been made, ready for additional review by human. |
Hello!I found the following issues in your plugin submission Errors: ❌ Could not parse This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved Conflicts
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1]:Please remove the [1]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. Optional[1]:Casting to Do NOT open a new PR for re-validation. |
Changes requested by bot have been made, ready for additional review by human. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Optional[1]:Casting to Do NOT open a new PR for re-validation. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/amatya-aditya/obsidian-media-slider
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.