-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: Wakatime / Wakapi #5438
base: master
Are you sure you want to change the base?
Conversation
Hello!I found the following issues in your plugin submission Errors: ❌ Please don't use the word This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2]:This class is only available on desktop, which means that this will throw errors on mobile (that's a problem since you have [1]:You should not cast this, instead use a [1]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to. [1][2]:Using Do NOT open a new PR for re-validation. |
All issues except innerHTML were resolved. The usage of innerHTML is not a security risk in this case, as it sets static html for an element. Using the DOM API would require 15+ lines of code and would have no benefit over innerHTML. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/Kovah/obsidian-wakatime
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.