obs-outputs: Attempt to generate path if one is not specified #11517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the MP4 muxer to attempt to use the path generation logic if a path is not explicitly specified. This allows MP4 muxer outputs to be configured with file splitting, without requiring both the `path` and `directory`+`format` fields to be specified (saving effort on the side of developers of custom plugins).
derrod
approved these changes
Nov 13, 2024
Comment on lines
+263
to
+264
| const char *path = obs_data_get_string(settings, "path"); | ||
| if (path && *path) { |
There was a problem hiding this comment.
I suppose this could be replaced with if (obs_data_has_user_value(settings, "path")) { but it's probably fine either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the MP4 muxer to attempt to use the path generation logic if a path is not explicitly specified. This allows MP4 muxer outputs to be configured with file splitting, without requiring both the
pathanddirectory+formatfields to be specified.Motivation and Context
Currently, the UI generates the initial recording path, then lets the output do it upon file splits. While this is great, it's not very friendly to usage of the output outside of the UI (saving effort on the side of developers of custom plugins).
How Has This Been Tested?
Used a script to create a custom
mp4_outputoutput in OBS, and configured it with justdirectory,format, andextensionfields, nopathfield. Output started correctly as expected, generating a path for the recording.Types of changes
Checklist: