mac-capture: Add SCStreamDelegate to stream to log capture errors #9065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a SCStreamDelegate logging when SCK sources stop with an error.
Motivation and Context
Having a delegate is needed for a future PR where we have to introduce some sort of UI feature that re-enables a stopped stream, as macOS 14 adds a UI for the user to stop SCK streams outside of OBS, or for when the computer goes to sleep (see #8928).
I'm also low-key hoping (at least a tiny bit) that it could help us diagnose remaining freezing issues that still pop up very sporadically (assuming that they exit with error codes), and as such wouldn't mind this change making its way into a hotfix release (assuming other people think that's acceptable).
How Has This Been Tested?
macOS 14
Put computer to sleep and (when waking it up again) saw the "Stream stopped with no capture source" message in the log.
Stopped the stream via the menu bar and saw the "User stopped stream" message.
Types of changes
Checklist: