Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac-capture: Add SCStreamDelegate to stream to log capture errors #9065

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

gxalpha
Copy link
Member

@gxalpha gxalpha commented Jun 10, 2023

Description

Adds a SCStreamDelegate logging when SCK sources stop with an error.

Motivation and Context

Having a delegate is needed for a future PR where we have to introduce some sort of UI feature that re-enables a stopped stream, as macOS 14 adds a UI for the user to stop SCK streams outside of OBS, or for when the computer goes to sleep (see #8928).
I'm also low-key hoping (at least a tiny bit) that it could help us diagnose remaining freezing issues that still pop up very sporadically (assuming that they exit with error codes), and as such wouldn't mind this change making its way into a hotfix release (assuming other people think that's acceptable).

How Has This Been Tested?

macOS 14
Put computer to sleep and (when waking it up again) saw the "Stream stopped with no capture source" message in the log.
Stopped the stream via the menu bar and saw the "User stopped stream" message.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@gxalpha gxalpha added Enhancement Improvement to existing functionality macOS Affects macOS labels Jun 10, 2023
@gxalpha gxalpha requested a review from PatTheMav June 10, 2023 22:23
@PatTheMav PatTheMav merged commit 59b5b07 into obsproject:master Jun 17, 2023
@gxalpha gxalpha deleted the scstreamdelegate branch June 17, 2023 14:46
@jcm93 jcm93 mentioned this pull request Jun 30, 2023
6 tasks
@RytoEX RytoEX added this to the OBS Studio (Next Release) milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality macOS Affects macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants