Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dream-html (2 packages) (3.9.5) #27194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[new release] dream-html (2 packages) (3.9.5) #27194

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
175c122
[new release] dream-html (2 packages) (3.9.5)
yawaramin Dec 29, 2024
db06a38
Bump up dream lower bound
yawaramin Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions packages/dream-html/dream-html.3.9.5/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
opam-version: "2.0"
synopsis: "HTML generator eDSL for Dream"
description:
"Write HTML directly in your OCaml source files with editor support."
maintainer: ["Yawar Amin <[email protected]>"]
authors: ["Yawar Amin <[email protected]>"]
license: "GPL-3.0-or-later"
tags: ["org:yawaramin"]
homepage: "https://github.com/yawaramin/dream-html"
doc: "https://yawaramin.github.io/dream-html/"
bug-reports: "https://github.com/yawaramin/dream-html/issues"
depends: [
"dune" {>= "3.0"}
"ocaml" {>= "4.14.0"}
"ppxlib" {>= "0.33.0" & < "1.0.0"}
"pure-html" {= version}
"dream" {>= "1.0.0~alpha7"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only relevant failure in CI is the lowe bounds check failing on

[ERROR] The compilation of dream.1.0.0~alpha7 failed at "dune build -p dream -j 39".

#=== ERROR while compiling dream.1.0.0~alpha7 =================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.3.0~beta1 | file:///home/opam/opam-repository
# path                 ~/.opam/5.3~beta1/.opam-switch/build/dream.1.0.0~alpha7
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p dream -j 39
# exit-code            1
# env-file             ~/.opam/log/dream-7-e90cf6.env
# output-file          ~/.opam/log/dream-7-e90cf6.out
### output ###
# File "src/http/dune", line 21, characters 2-32:
# 21 |   dream-httpaf.dream-websocketaf
#        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Library "dream-httpaf.dream-websocketaf" not found.
# -> required by library "dream.http" in _build/default/src/http
# -> required by _build/default/META.dream
# -> required by _build/install/default/lib/dream/META
# -> required by _build/default/dream.install
# -> required by alias install

Since you know dream quite well, iiuc, do you know if this is a packaging error on the side of dream? Could it be avoided for your package perhaps just by raising the lower bound to dream alpha8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think this is because of #27062. Sure, we can try bumping the lower bound.

"odoc" {with-doc}
]
build: [
["dune" "subst"] {dev}
[
"dune"
"build"
"-p"
name
"-j"
jobs
"@install"
"@runtest" {with-test}
"@doc" {with-doc}
]
]
dev-repo: "git+https://github.com/yawaramin/dream-html.git"
url {
src:
"https://github.com/yawaramin/dream-html/releases/download/v3.9.5/dream-html-3.9.5.tbz"
checksum: [
"sha256=61218e64561b5f2f74b866af750018717046fe333bf48c7fa4192d632e1250e7"
"sha512=a0f35373434c3e847b0a3c527e7539aa587ea7b1bf36e627a0a753a44932eabba0865ba179b27259b58a3503070c17080de37fc5d9d73931ac8e6bb3b59a073f"
]
}
x-commit-hash: "7504c0d53d464812b3056071894e93bf04c49b09"
40 changes: 40 additions & 0 deletions packages/pure-html/pure-html.3.9.5/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
opam-version: "2.0"
synopsis: "HTML generator eDSL"
description:
"Write HTML directly in your OCaml source files with editor support."
maintainer: ["Yawar Amin <[email protected]>"]
authors: ["Yawar Amin <[email protected]>"]
license: "GPL-3.0-or-later"
tags: ["org:yawaramin"]
homepage: "https://github.com/yawaramin/dream-html"
doc: "https://yawaramin.github.io/dream-html/"
bug-reports: "https://github.com/yawaramin/dream-html/issues"
depends: [
"dune" {>= "3.0"}
"uri" {>= "4.4.0" & < "5.0.0"}
"odoc" {with-doc}
]
build: [
["dune" "subst"] {dev}
[
"dune"
"build"
"-p"
name
"-j"
jobs
"@install"
"@runtest" {with-test}
"@doc" {with-doc}
]
]
dev-repo: "git+https://github.com/yawaramin/dream-html.git"
url {
src:
"https://github.com/yawaramin/dream-html/releases/download/v3.9.5/dream-html-3.9.5.tbz"
checksum: [
"sha256=61218e64561b5f2f74b866af750018717046fe333bf48c7fa4192d632e1250e7"
"sha512=a0f35373434c3e847b0a3c527e7539aa587ea7b1bf36e627a0a753a44932eabba0865ba179b27259b58a3503070c17080de37fc5d9d73931ac8e6bb3b59a073f"
]
}
x-commit-hash: "7504c0d53d464812b3056071894e93bf04c49b09"
Loading