Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coq-serapi < 0.20 needs upper bound on ocamlfind #27310

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

mseri
Copy link
Member

@mseri mseri commented Jan 23, 2025

Seen on #27253

Fails with

#=== ERROR while compiling coq-serapi.8.19.0+0.19.3 ===========================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/coq-serapi.8.19.0+0.19.3
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p coq-serapi -j 255
# exit-code            1
# env-file             ~/.opam/log/coq-serapi-7-2a48f7.env
# output-file          ~/.opam/log/coq-serapi-7-2a48f7.out
### output ###
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -g -ppx '.ppx/57e0400f3b219ff4fc65d1fbd820e35d/ppx.exe --as-ppx --cookie '\''library-name="sertop"'\''' -bin-annot -I sertop/.sertop.objs/byte -I /home/opam/.opam/4.14/lib/base -I /home/opam/.opam/4.14/lib/base/base_internalhash_types -I /home/opam/.opam/4.14/lib/base/caml -I /home/opam/.opam/4.14/lib/base/shadow_stdlib -I /home/opam/.opam/4.14/lib/cmdliner -I /home/opam/.opam/4.14/lib/coq-core/boot -I /home/opam/.opam/4.14/lib/coq-core/clib -I /home/opam/.opam/4.14/lib/coq-core/config -I /home/opam/.opam/4.14/lib/coq-core/coqworkmgrapi -I /home/opam/.opam/4.14/lib/coq-core/engine -I /home/opam/.opam/4.14/lib/coq-core/gramlib -I /home/opam/.opam/4.14/lib/coq-core/interp -I /home/opam/.opam/4.14/lib/coq-core/kernel -I /home/opam/.opam/4.14/lib/coq-core/lib -I /home/opam/.opam/4.14/lib/coq-core/library -I /home/opam/.opam/4.14/lib/coq-core/parsing -I /home/opam/.opam/4.14/lib/coq-core/perf -I /home/opam/.opam/4.14/lib/coq-core/plugins/ltac -I /home/opam/.opam/4.14/lib/coq-core/pretyping -I /home/opam/.opam/4.14/lib/coq-core/printing -I /home/opam/.opam/4.14/lib/coq-core/proofs -I /home/opam/.opam/4.14/lib/coq-core/stm -I /home/opam/.opam/4.14/lib/coq-core/sysinit -I /home/opam/.opam/4.14/lib/coq-core/tactics -I /home/opam/.opam/4.14/lib/coq-core/vernac -I /home/opam/.opam/4.14/lib/coq-core/vm -I /home/opam/.opam/4.14/lib/findlib -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/parsexp -I /home/opam/.opam/4.14/lib/ppx_compare/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_deriving/runtime -I /home/opam/.opam/4.14/lib/ppx_deriving_yojson/runtime -I /home/opam/.opam/4.14/lib/ppx_hash/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/seq -I /home/opam/.opam/4.14/lib/sexplib -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/yojson -I /home/opam/.opam/4.14/lib/zarith -I serapi/.serapi.objs/byte -I serlib/.serlib.objs/byte -I serlib/plugins/ltac/.serlib_ltac.objs/byte -intf-suffix .ml -no-alias-deps -open Sertop -o sertop/.sertop.objs/byte/sertop__Sertop_loader.cmo -c -impl sertop/sertop_loader.ml)
# File "sertop/sertop_loader.ml", line 1:
# Error: The implementation sertop/sertop_loader.ml
#        does not match the interface sertop/.sertop.objs/byte/sertop__Sertop_loader.cmi:
#         Values do not match:
#           val plugin_handler :
#             (?loadfile:(string -> unit) -> string list -> unit) option ->
#             Mltop.PluginSpec.t -> unit
#         is not included in
#           val plugin_handler :
#             (string list -> unit) option -> Mltop.PluginSpec.t -> unit
#         The type
#           (?loadfile:(string -> unit) -> string list -> unit) option ->
#           Mltop.PluginSpec.t -> unit
#         is not compatible with the type
#           (string list -> unit) option -> Mltop.PluginSpec.t -> unit
#         Type ?loadfile:(string -> unit) -> string list -> unit
#         is not compatible with type string list -> unit 
#         File "sertop/sertop_loader.mli", line 21, characters 0-79:
#           Expected declaration
#         File "sertop/sertop_loader.ml", line 53, characters 4-18:
#           Actual declaration
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlopt.opt -w -40 -g -ppx '.ppx/57e0400f3b219ff4fc65d1fbd820e35d/ppx.exe --as-ppx --cookie '\''library-name="sertop"'\''' -I sertop/.sertop.objs/byte -I sertop/.sertop.objs/native -I /home/opam/.opam/4.14/lib/base -I /home/opam/.opam/4.14/lib/base/base_internalhash_types -I /home/opam/.opam/4.14/lib/base/caml -I /home/opam/.opam/4.14/lib/base/shadow_stdlib -I /home/opam/.opam/4.14/lib/cmdliner -I /home/opam/.opam/4.14/lib/coq-core/boot -I /home/opam/.opam/4.14/lib/coq-core/clib -I /home/opam/.opam/4.14/lib/coq-core/config -I /home/opam/.opam/4.14/lib/coq-core/coqworkmgrapi -I /home/opam/.opam/4.14/lib/coq-core/engine -I /home/opam/.opam/4.14/lib/coq-core/gramlib -I /home/opam/.opam/4.14/lib/coq-core/interp -I /home/opam/.opam/4.14/lib/coq-core/kernel -I /home/opam/.opam/4.14/lib/coq-core/lib -I /home/opam/.opam/4.14/lib/coq-core/library -I /home/opam/.opam/4.14/lib/coq-core/parsing -I /home/opam/.opam/4.14/lib/coq-core/perf -I /home/opam/.opam/4.14/lib/coq-core/plugins/ltac -I /home/opam/.opam/4.14/lib/coq-core/pretyping -I /home/opam/.opam/4.14/lib/coq-core/printing -I /home/opam/.opam/4.14/lib/coq-core/proofs -I /home/opam/.opam/4.14/lib/coq-core/stm -I /home/opam/.opam/4.14/lib/coq-core/sysinit -I /home/opam/.opam/4.14/lib/coq-core/tactics -I /home/opam/.opam/4.14/lib/coq-core/vernac -I /home/opam/.opam/4.14/lib/coq-core/vm -I /home/opam/.opam/4.14/lib/findlib -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/parsexp -I /home/opam/.opam/4.14/lib/ppx_compare/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_deriving/runtime -I /home/opam/.opam/4.14/lib/ppx_deriving_yojson/runtime -I /home/opam/.opam/4.14/lib/ppx_hash/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/seq -I /home/opam/.opam/4.14/lib/sexplib -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/yojson -I /home/opam/.opam/4.14/lib/zarith -I serapi/.serapi.objs/byte -I serapi/.serapi.objs/native -I serlib/.serlib.objs/byte -I serlib/.serlib.objs/native -I serlib/plugins/ltac/.serlib_ltac.objs/byte -I serlib/plugins/ltac/.serlib_ltac.objs/native -intf-suffix .ml -no-alias-deps -open Sertop -o sertop/.sertop.objs/native/sertop__Sertop_loader.cmx -c -impl sertop/sertop_loader.ml)
# File "sertop/sertop_loader.ml", line 1:
# Error: The implementation sertop/sertop_loader.ml
#        does not match the interface sertop/.sertop.objs/byte/sertop__Sertop_loader.cmi:
#         Values do not match:
#           val plugin_handler :
#             (?loadfile:(string -> unit) -> string list -> unit) option ->
#             Mltop.PluginSpec.t -> unit
#         is not included in
#           val plugin_handler :
#             (string list -> unit) option -> Mltop.PluginSpec.t -> unit
#         The type
#           (?loadfile:(string -> unit) -> string list -> unit) option ->
#           Mltop.PluginSpec.t -> unit
#         is not compatible with the type
#           (string list -> unit) option -> Mltop.PluginSpec.t -> unit
#         Type ?loadfile:(string -> unit) -> string list -> unit
#         is not compatible with type string list -> unit 
#         File "sertop/sertop_loader.mli", line 21, characters 0-79:
#           Expected declaration
#         File "sertop/sertop_loader.ml", line 53, characters 4-18:
#           Actual declaration

@mseri
Copy link
Member Author

mseri commented Jan 23, 2025

lint has passed

@mseri mseri merged commit 4770d64 into ocaml:master Jan 23, 2025
1 of 3 checks passed
@mseri mseri deleted the coq-serapi branch January 23, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant