Trivial fix, histogram_zero_line_t being incorrect with scale_min < 0 and scale_max > 0 #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocornut
force-pushed
the
master
branch
2 times, most recently
from
0c1e5bd to
bb6a60b
Compare
ocornut
pushed a commit
that referenced
this pull request
Aug 31, 2021
…0 and max>0. (#4349) + amended demo tweaks by ocornut
|
Thank you for the PR. Merged as eb6c16d! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a really small fix. I guess nobody has histograms with negative values.
min < 0
max > 0
0 at the top
1 at the bottom
zero_line_t = 1 - (-min / (max-min)) = 1 + min / (max - min)