WebGPU: fix image leaks and allow reuse of WGPUTextureView #8046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't store the bind groups during all the execution because user could release the texture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7765 & #8027.
A minor counterpart of removing
ImageBindGroupis that it is now released an recreated each frame where a call toImGui::Imageis done to display default font texture. I'm not sure is this is really a performance issue, but it could be handled otherwise if needed.Also I am not sure of the pattern used for
SafeRelease<WGPUBindGroup>. I'm not really familiar with ImGui's code style, so I am open to suggestion if you'd rather have this implemented differently.